Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors some of the BaseProxy __init__ methods code to better support the reading in of RPC credentials.
Currently the code will only attempt to read in a cookie file if a configuration file exists and a valid
rpcpassword
variable is not found in it. This change will fail silently if the configuration file does not exist or is unable to be read (permission issue, etc.), continuing on to try to read a cookie file. if we are unable to find valid credentials in a configuration file and also not able to read a cookie file then we fail and alert the user.This also fixes a bug introduced in #144 where only passing in a service_url to one of the Proxy classes resulted in an UnboundLocalError like:
authpair is now checked prior to making the connection and if it is None we assign the parsed username/password from service_url